Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor incompatibility with Elytra Physics #5

Open
SplendidAlakey opened this issue Jul 29, 2022 · 3 comments
Open

Minor incompatibility with Elytra Physics #5

SplendidAlakey opened this issue Jul 29, 2022 · 3 comments

Comments

@SplendidAlakey
Copy link

SplendidAlakey commented Jul 29, 2022

MC 1.19.1
Fabric API 0.58.5
Elytra Physics 1.0.2
The Box Trot 1.4

When wearing a barrel on your head at the same time as elytra, the elytra gets flipped and turned sideways. Somewhat similar to #3?

The issue is minor enough that I'm willing to ignore it + Elytra Physics doesn't seem to be open source, despite having an MIT license. Also no way to report to them, so reporting here in case that's something that can be fixed on your side.

2022-07-29_06 20 38

Logs: https://gist.github.com/SplendidAlakey/322def0c2342564544ce71ddd6cbb3d4

@CammiePone
Copy link
Owner

ik what's causing it, not totally sure if I can fix it easily, but I can try

@SplendidAlakey
Copy link
Author

Thanks for looking into it. Also might not be an incompatibility at all since the person from #4 actually reported the same thing it seems, without any extra mods. I didn't test the mod just on its own, oops...

@CammiePone
Copy link
Owner

no no, basically the problem is Minecraft renders everything upside down, so in order to render the box right, i have to flip the matrix stack, and for whatever reason that's bleeding to trinket renders when it shouldnt be

the easiest fix would be to reflip the matrix stack after rendering the box, but that's a bit janky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants