Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0 dBm equates to "OFF" with DDS even when allowed range includes 0 dBm #221

Open
aransfor opened this issue Mar 5, 2018 · 0 comments
Open
Assignees
Labels

Comments

@aransfor
Copy link
Contributor

aransfor commented Mar 5, 2018

https://github.com/CampbellGroup/common/blob/master/lib/servers/Pulser2/dds.py#L96-L98

@theoriginaljuice The code here clear checks for 0 frequency and 0 amplitude as 'OFF', I think 0 frequency is enough and we just delete that line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants