Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule with polymorphic relationship fails #290

Closed
mrloop opened this issue Jan 20, 2016 · 1 comment
Closed

Rule with polymorphic relationship fails #290

mrloop opened this issue Jan 20, 2016 · 1 comment
Assignees
@coorasse
Labels
bug

Comments

@mrloop
Copy link

mrloop commented Jan 20, 2016

Here's a test which fails mrloop@aba0a06. Initial error for polymorphic test was uninitialized constant VideoEncoding::VideoEncodable.
Solving this with this commit, mrloop@7907912, and now have a problem eagerly loading polymorphic relationship. Can not eagerly load the polymorphic association :video_encodable
Thinking I need to update https://github.com/mrloop/cancancan/blob/polymorphic/lib/cancan/model_adapters/active_record_4_adapter.rb#L15 somehow, any suggestions welcome.
@Senjai Senjai self-assigned this Aug 7, 2016
@coorasse coorasse added the bug label Sep 2, 2018
@coorasse coorasse assigned coorasse and unassigned Senjai Sep 2, 2018
@coorasse
Copy link
Member

Closed because of starvation.
Please feel free to reopen if this issue is still valid or interested in solving with a PR.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coorasse coorasse

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrloop @coorasse @Senjai