Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Not able to access CropImage.activity() function in Java class #108

Closed
prashant-13 opened this issue Apr 11, 2021 · 10 comments · Fixed by #109
Closed

[BUG] - Not able to access CropImage.activity() function in Java class #108

prashant-13 opened this issue Apr 11, 2021 · 10 comments · Fixed by #109

Comments

@prashant-13
Copy link
Contributor

  • Lib Version [2.3.1]

Not able to call CropImage.activity() fun, it is giving error. As it is not mentioned with @JvmStatic annotation. Please add @JvmStatic in fun activity() so that we can use this lib in java project

@Canato
Copy link
Member

Canato commented Apr 11, 2021

@prashant-13 can you please open a PR with this changes so I can release fast?

Ideally, if you have time, not mandatory, we could add a Java Sample code. So we can be sure this will not happens again ^^

@Canato Canato added the pinned label Apr 11, 2021
@mampress
Copy link

Have you fixed it? Thanks in advance

@Canato
Copy link
Member

Canato commented Apr 12, 2021

@mampress when is fixed and release this issue will be close. Someone need to drop a PR to fix this so we can merge =)

@mampress
Copy link

Sorry, I'm quite new to GitHub so I don't know how to open one

@Canato
Copy link
Member

Canato commented Apr 12, 2021

@mampress welcome =D

This is the library guide to contribute, our "rules".

This is a great guide explaining how to fork and how to contribute.

Looking forward for your PR soon !!!

@mampress
Copy link

mampress commented Apr 12, 2021

As soon as I understand what a PR properly is I'll commit one =D, I hope soon since I'm working on a project with this library

@ashcode1997
Copy link

@mampress how did u reesolved the problem ?

@mampress
Copy link

@mampress how did u reesolved the problem ?

haven't resolved it yet

@Canato
Copy link
Member

Canato commented Apr 12, 2021

@prashant-13 Thanks for the PR!

@ashcode1997 @mampress
Please check the pre-release 2.3.2-alpha and let me know on the discussion #110 if everything is working

@Canato
Copy link
Member

Canato commented Apr 13, 2021

@NmMedina will work on this #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants