Autoremove reporting #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simpoir
force-pushed
the
autoremove_reporting
branch
from
d2e534f
to
4073ccb
Compare
ericsnowcurrently
approved these changes
Jul 25, 2017
|
|
||
| self.store.set_hash_ids({HASH1: 1, HASH2: 2, HASH3: 3}) | ||
| self.store.add_available([1, 2, 3]) | ||
| self.store.add_autoremovable([1, 2]) |
There was a problem hiding this comment.
It may be worth adding a note here pointing out that add_installed() is never called, which is why not-autoremovable is what it is.
FWIW, I also find this approach to exercising not-autoremovable to be a little odd. At what point would the store mark a package as auto-removable but not installed?
There was a problem hiding this comment.
Don't confuse the client store state with the apt package status. Unless the apt package is marked auto and not depended upon, it would still be flagged as not-autoremovable. It's true that in practice the installed state will come with autoremovable state in the store, but I don't care about exercising that path in this test.
I'll add a comment. on the logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes adds client bits to report autoremovable packages back to landscape-server so it can act on them. lp:1208393
Testing:
sudo apt-get install sl && sudo apt-mark auto sl && apt-get autoremove --dry-run
sudo ./scripts/landscape-client -c root-client.conf
accept in landscape, wait forever for package data to sync or not (server doesn't know about that field)
/tmp/landscape-root/package-reporter.log should queue autoremovable once (those are diffs)
grep autoremovable /tmp/landscape-root/broker.log # shows package report being sent even if currently ignored by servers