Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop reactor in landscape-config on broker error. #13

Merged
merged 1 commit into from Aug 29, 2017

Conversation

simpoir
Copy link
Contributor

@simpoir simpoir commented Aug 28, 2017

Handle SystemExit exception, as those don't propagate past the reactor.
This will avoid hanging forever in environements (installer-chroot) where the broker will not start.

To test: ln -s /bin/echo /etc/init.d/landscape-client && sudo ./scripts/landscape-config --silent
Script should timeout and not run forever.

Handle SystemExit exception, as those don't propagate past the reactor.
Copy link
Contributor

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simpoir simpoir merged commit e0b1b0c into canonical:master Aug 29, 2017
@simpoir simpoir deleted the catch_systemexit_in_config branch August 29, 2017 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants