Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return non-blank message when tasks already performed #46

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Return non-blank message when tasks already performed #46

merged 1 commit into from
Apr 23, 2018

Conversation

waveform80
Copy link
Member

@waveform80 waveform80 commented Apr 19, 2018 •
edited

In the case that all tasks have already been performed (e.g. by external processes), return a meaningful message rather than nothing. (LP: #928933)

@waveform80
Fix #928933
1ee5def 
In the case that all tasks have already been (e.g. by external
processes), return a meaningful message rather than nothing.
simpoir
simpoir approved these changes Apr 20, 2018
View reviewed changes
Copy link
Contributor

@simpoir simpoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks good

The test assertion for unicode, while other tests check for strings feels weird, but in this case it seems accurate.

@waveform80 waveform80 changed the title Fix #928933 Return non-blank message when tasks already performed Apr 20, 2018
@waveform80 waveform80 merged commit dcabc66 into canonical:master Apr 23, 2018
@waveform80 waveform80 deleted the 928933_no_output branch April 23, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simpoir simpoir simpoir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@waveform80 @simpoir