Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RHEV to vm_info map. (LP: #1884116) #86

Merged
merged 3 commits into from
Nov 16, 2020

Conversation

simpoir
Copy link
Contributor

@simpoir simpoir commented Jul 17, 2020

Testing instructions:

The easy way to verify this is to run the unit tests.
The proper way to verify this is to spawn a kvm and virsh edit

and add a <smbios mode="sysinfo"/> under <os>, and a sysinfo block after </os>:

<sysinfo type='smbios'>
  <bios>
    <entry name='vendor'>LENOVO</entry>
  </bios>
  <system>
    <entry name='manufacturer'>Red Hat</entry>
    <entry name='product'>RHEV Hypervisor</entry>
    <entry name='version'>7.8-2.el7ev</entry>
  </system>
  <chassis>
    <entry name='manufacturer'>Red Hat</entry>
  </chassis>
</sysinfo>

The other way is to have an RHEV install.

Copy link
Contributor

@maxiberta maxiberta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simpoir simpoir merged commit 07b68d9 into canonical:master Nov 16, 2020
@simpoir simpoir deleted the 1884116_rhev branch November 16, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants