Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to preprocess RAM / disk size request between daemon and hypervisors #616

Closed
Saviq opened this issue Feb 20, 2019 · 1 comment
Closed

Need to preprocess RAM / disk size request between daemon and hypervisors #616

Saviq opened this issue Feb 20, 2019 · 1 comment
Assignees
@ricab
Labels
enhancement
Projects
19.04 cycle

Comments

@Saviq
Copy link
Collaborator

Saviq commented Feb 20, 2019

Today we pass the memory / disk size requests verbatim to the hypervisor backends, meaning they all need to deal themselves with [KMG]?B? suffixes.

We should instead ensure the value is sanitized and unified before handing it off to the backends so they only need to deal with preparing it for the hypervisor in question.
@ricab ricab self-assigned this Feb 21, 2019
@Saviq Saviq added this to To do in 19.04 cycle via automation Feb 22, 2019
ricab added a commit that referenced this issue Feb 22, 2019
@ricab
Implement memory value normalization.
5c50093 
Implement verification and normalization of memory values in a single step. Use that in the daemon, replacing mere validation. Update hostname validation for consistency. Update tests accordingly. Fixes #616.
ricab added a commit that referenced this issue Feb 26, 2019
@ricab
Implement memory value normalization.
5900e05 
Implement verification and normalization of memory values in a single step. Use that in the daemon, replacing mere validation. Update hostname validation for consistency. Update tests accordingly. Fixes #616.
ricab added a commit that referenced this issue Feb 28, 2019
@ricab
Implement memory value normalization.
b03ef72 
Implement verification and normalization of memory values in a single step. Use that in the daemon, replacing mere validation. Update hostname validation for consistency. Update tests accordingly. Fixes #616.
@townsend2010 townsend2010 moved this from To do to In progress in 19.04 cycle Feb 28, 2019
ricab added a commit that referenced this issue Mar 1, 2019
@ricab
Implement memory value normalization.
5010918 
Implement verification and normalization of memory values in a single step. Use that in the daemon, replacing mere validation. Update hostname validation for consistency. Update tests accordingly. Fixes #616.
ricab added a commit that referenced this issue Mar 8, 2019
@ricab
Implement memory value normalization.
faa019d 
Implement verification and normalization of memory values in a single step. Use that in the daemon, replacing mere validation. Update hostname validation for consistency. Update tests accordingly. Fixes #616.
@ricab
Copy link
Contributor

ricab commented Mar 13, 2019

This wasn't automatically closed for some reason. Closing manually.

@ricab ricab closed this as completed Mar 13, 2019
19.04 cycle automation moved this from In progress to Done Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricab ricab

Labels
enhancement
Projects
No open projects
19.04 cycle
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Saviq @ricab