Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multipass launch… should work offline for all cached images #829

Closed
Saviq opened this issue Jun 10, 2019 · 0 comments · Fixed by #834
Closed

multipass launch… should work offline for all cached images #829

Saviq opened this issue Jun 10, 2019 · 0 comments · Fixed by #834
Assignees
@townsend2010
Labels
bug
Projects
19.10 cycle v0.8.0

Comments

@Saviq
Copy link
Collaborator

Saviq commented Jun 10, 2019

Today when the daemon is started with no network, the daemon just decides there's no images:

$ multipass find
No images found.
$ multipass launch 
launch failed: Remote "" is unknown or unreachable.

We should cache at least enough of the image metadata along with the images to make this work.
@Saviq Saviq added the bug label Jun 10, 2019
@Saviq Saviq added this to To do in 19.10 cycle via automation Jun 10, 2019
@townsend2010 townsend2010 self-assigned this Jun 10, 2019
townsend2010 added a commit that referenced this issue Jun 11, 2019
@townsend2010
url_downloader: Directly use network cache when downloading data
37d5434 
Due to how QNetwork handles caching via QNetworkAccessManager and issues it
causes, instead directly access the network cache. This includes comparing the
Last-Modified header of the URL to what is cached and also use cached data (if
availble) when there is an issue downloading the data from the URL.

Fixes #825, fixes #829
@townsend2010 townsend2010 mentioned this issue Jun 11, 2019
Merged
@townsend2010 townsend2010 moved this from To do to In progress in 19.10 cycle Jun 13, 2019
bors bot added a commit that referenced this issue Jun 14, 2019
@bors @townsend2010
Merge #834
af773b8 
834: url_downloader: Directly use network cache when downloading data r=gerboland a=townsend2010

Due to how QNetwork handles caching via QNetworkAccessManager and issues it
causes, instead directly access the network cache. This includes comparing the
Last-Modified header of the URL to what is cached and also use cached data (if
availble) when there is an issue downloading the data from the URL.

Fixes #825, fixes #829

Co-authored-by: Chris Townsend <christopher.townsend@canonical.com>
@bors bors bot closed this as completed in #834 Jun 14, 2019
19.10 cycle automation moved this from In progress to Done Jun 14, 2019
Saviq pushed a commit that referenced this issue Jun 17, 2019
@bors @townsend2010 @Saviq
Merge #834
a5a157b 
834: url_downloader: Directly use network cache when downloading data r=gerboland a=townsend2010

Due to how QNetwork handles caching via QNetworkAccessManager and issues it
causes, instead directly access the network cache. This includes comparing the
Last-Modified header of the URL to what is cached and also use cached data (if
availble) when there is an issue downloading the data from the URL.

Fixes #825, fixes #829

Co-authored-by: Chris Townsend <christopher.townsend@canonical.com>
@Saviq Saviq mentioned this issue Jun 17, 2019
Merged
@Saviq Saviq added this to Done in v0.8.0 via automation Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@townsend2010 townsend2010

Labels
bug
Projects
No open projects
19.10 cycle
  
Done
v0.8.0
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

url_downloader: Directly use network cache when downloading data canonical/multipass
2 participants
@Saviq @townsend2010