On netplan apply, tolerate devices that do not appear in /sys/class/net
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 34 34
Lines 4005 4005
=====================================
Hits 4005 4005Continue to review full report at Codecov.
|
When using the NetworkManager renderer, the logic in `NetplanApply.command_apply()` tells `nmcli` to disconnect the devices previously populated by `netifaces.interfaces()`. In addition, if an alias like "eth0:0" exists, it will show as a device from `netifaces.interfaces()` but will not have a path in `/sys/class/net`. This means that the `devices` variable may have more devices than actually exist due to the past `nmcli device disconnect` run or the presence of one or more aliases. The attached patch fixes this bug by tolerating all errors from `udevadm test-builtin net_setup_link /sys/class/net/XXX` so that `netplan apply` doesn't quit and leave the user without a network setup. Fixes LP #1810043 Launchpad: https://bugs.launchpad.net/netplan/+bug/1810043 Signed-off-by: Nick Liu <deltik@gmx.com>
Deltik
changed the title
nmcli device disconnect runs/sys/class/net on netplan apply
Deltik
changed the title
/sys/class/net on netplan applynetplan apply, tolerate devices that do not appear in /sys/class/net
cyphermox
approved these changes
May 14, 2019
|
Seems this patch isn't applied in Debian Buster I'm using Netplan on Raspbian Buster, and I had to apply the patch manually. |
|
Still no changes in Debian Buster =( |
|
@YamiYukiSenpai and @ep4sh: Comments about packaging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the NetworkManager renderer, the logic in
NetplanApply.command_apply()tellsnmclito disconnect the devices previously populated bynetifaces.interfaces().In addition, if an alias like "eth0:0" exists, it will show as a device from
netifaces.interfaces()but will not have a path in/sys/class/net.This means that the
devicesvariable may have more devices than actually exist due to the pastnmcli device disconnectrun or the presence of one or more aliases.This merge request fixes this bug by tolerating all errors from
udevadm test-builtin net_setup_link /sys/class/net/XXXso thatnetplan applydoesn't quit and leave the user without a network setup.Fixes Launchpad bug #1810043
Checklist
make checksuccessfully.make check-coverage).