Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display free/used inodes #23

Closed
daniejstriata opened this issue Nov 3, 2021 · 17 comments
Closed

display free/used inodes #23

daniejstriata opened this issue Nov 3, 2021 · 17 comments

Comments

@daniejstriata
Copy link

Can you please add option to add a column for free/used inodes?

@Canop
Copy link
Owner

Canop commented Nov 3, 2021

In the JSON output, why not, but is this a so frequent concern that you'd also want it in the table view ?

@daniejstriata
Copy link
Author

only Display inodes column if I ask for it?

I run lfs as part of my motd. It would be good for me to show inodes issues to admins logging in,

@Canop
Copy link
Owner

Canop commented Nov 3, 2021

I'll probably do it, as it's quite easy

@Canop
Copy link
Owner

Canop commented Nov 3, 2021

Not 100% sure about the presentation but I might settle for this:

image

I've also tested with % but it doesn't really help IMO:

image

@daniejstriata
Copy link
Author

daniejstriata commented Nov 3, 2021

There are other ways to get the exact inodes total and used. I'd be happy just to see the percentage of inodes in use.

@Canop
Copy link
Owner

Canop commented Nov 3, 2021

You mean your opinion would be to choose just "free inodes" and "inodes use%" ?

@daniejstriata
Copy link
Author

daniejstriata commented Nov 3, 2021

Yes. I've never worried about inodes until there are none left :-) I actually ran into an XFS volume today that started complaining about inodes. I've not seen xfs having inode issues before.

@Canop
Copy link
Owner

Canop commented Nov 3, 2021

As you can see, it's not really my current concern:
image

@Canop
Copy link
Owner

Canop commented Nov 3, 2021

In a future versions, I'll probably make it possible to finely decide what cols to display...

@Canop
Copy link
Owner

Canop commented Nov 3, 2021

(depending on whether I have another user or not ^^)

@daniejstriata
Copy link
Author

daniejstriata commented Nov 3, 2021

That example looks great. I would even drop the free inodes column.

Choosing column in future could be helpful. Maybe have a "lite" and "full" option?

full:

┌───┬─────┬─────────────────────────────────┬────┬────┬────┬─────────┬────┬────┬───────────┐
│ id│ dev │           filesystem            │disk│type│used│  use%   │free│size│mount point│
├───┼─────┼─────────────────────────────────┼────┼────┼────┼─────────┼────┼────┼───────────┤
│150│253:1│/dev/mapper/root                 │LVM │xfs │26G │59% ███  │ 18G│44G │/          │
│112│253:1│/dev/mapper/root                 │LVM │xfs │26G │59% ███  │ 18G│44G │/var/tmp   │
│169│253:3│/dev/mapper/home                 │LVM │xfs │14G │66% ███▎ │7.4G│21G │/home      │
│166│252:1│/dev/vda1                        │HDD │ext4│287M│28% █▍   │736M│1.0G│/boot      │
└───┴─────┴─────────────────────────────────┴────┴────┴────┴─────────┴────┴────┴───────────┘

lite:

┌─────────────────────────────────┬────┬────┬─────────┬────┬────┬───────────┐
│           filesystem            │type│used│  use%   │free│size│mount point│
├─────────────────────────────────┼────┼────┼─────────┼────┼────┼───────────┤
│/dev/mapper/root                 │xfs │26G │59% ███  │ 18G│44G │/          │
│/dev/mapper/root                 │    │26G │59% ███  │ 18G│44G │/var/tmp   │
│/dev/mapper/home                 │xfs │14G │66% ███▎ │7.4G│21G │/home      │
│/dev/vda1                        │ext4│287M│28% █▍   │736M│1.0G│/boot      │
└─────────────────────────────────┴────┴────┴─────────┴────┴────┴───────────┘

@Canop
Copy link
Owner

Canop commented Nov 3, 2021

Let's see:

image

@daniejstriata
Copy link
Author

That looks good. What if you add the new inodes column after the use%

@Canop
Copy link
Owner

Canop commented Nov 3, 2021

I don't want to mix parts in bytes and parts in inodes, that would be ambiguous

@Canop
Copy link
Owner

Canop commented Nov 3, 2021

I'll go with this for now (testing with a fs without inode):

image

@Canop Canop closed this as completed in 3860c14 Nov 3, 2021
@Canop
Copy link
Owner

Canop commented Nov 3, 2021

Released. I've spent more time than expected on the tests and small details...

@daniejstriata
Copy link
Author

I appreciate! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants