Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question mark doesn't work #7

Closed
0x7FFFFFFFFFFFFFFF opened this issue Oct 7, 2021 · 6 comments
Closed

Question mark doesn't work #7

0x7FFFFFFFFFFFFFFF opened this issue Oct 7, 2021 · 6 comments

Comments

@0x7FFFFFFFFFFFFFFF
Copy link
Contributor

I'm using v0.2.5 and when safecloset starts, the ? shortcut has never worked. Below is the log. I started safecloset, pressed ? three times and ctrl+x exited. It seems safecloset did receive the key.

08:38:15.620 [INFO] cli_log::init: Starting safecloset v0.2.5 with log level DEBUG
08:38:15.621 [INFO] safecloset::cli: args: Args {
    version: false,
    hide: false,
    open: false,
    path: Some(
        "test",
    ),
}
08:38:15.888 [DEBUG] safecloset::tui::app: user event: Ok(Resize(107, 29))
08:38:20.380 [DEBUG] safecloset::tui::app: user event: Ok(Key(KeyEvent { code: Char('?'), modifiers: SHIFT }))
08:38:20.747 [DEBUG] safecloset::tui::app: user event: Ok(Key(KeyEvent { code: Char('?'), modifiers: SHIFT }))
08:38:21.077 [DEBUG] safecloset::tui::app: user event: Ok(Key(KeyEvent { code: Char('?'), modifiers: SHIFT }))
08:38:23.290 [DEBUG] safecloset::tui::app: user event: Ok(Key(KeyEvent { code: Char('x'), modifiers: CONTROL }))
08:38:23.290 [DEBUG] safecloset::tui::app_state: user requests save and quit
08:38:23.290 [DEBUG] safecloset::tui::app_state: self.close_drawer_input(false) took 300ns
08:38:23.290 [DEBUG] safecloset::tui::app: user requests quit
08:38:23.290 [INFO] safecloset: bye

Also as you can see in the following screen snapshot, there are duplicate help information at the bottom when I started safecloset.
image
The length of the first help line is not equal to the second line, which is a little weird. For example, when I copy a cell, it looks like this.
image

@Canop
Copy link
Owner

Canop commented Oct 7, 2021

There are two problems here:

  • a "resizing" problem. I must search
  • Windows sending ? as shift-?. This one can be easily fixed

@0x7FFFFFFFFFFFFFFF
Copy link
Contributor Author

I don't know. But in order to send ?, I have to press shift+?/.

@Canop
Copy link
Owner

Canop commented Oct 8, 2021

I know this. It's also the case for me. But the OS should send the ? key code without the shift even if you physically have to press both: the key code is normally independent of the physical layout.

Can you test the new windows-question-mark branch ?

@0x7FFFFFFFFFFFFFFF
Copy link
Contributor Author

Yes, the ? can trigger help information now! Thanks for the improvement. The "resizing" problem still exists.

@Canop
Copy link
Owner

Canop commented Oct 8, 2021

The resizing problem is totally unrelated. I remember I had the same problem at the beginning of broot for Windows users, I'll search my archives.

@0x7FFFFFFFFFFFFFFF
Copy link
Contributor Author

Oh, I just noticed you are the author of broot! I'm new in the Rust community, but I've tried broot in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants