Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support asyncpg 0.22.0 #111

Merged
merged 4 commits into from Feb 12, 2021
Merged

Conversation

Gr1N
Copy link
Contributor

@Gr1N Gr1N commented Feb 10, 2021

Hi!

The new release of asyncpg 0.22.0 breaks compatibility with asyncpgsa and here is a simple fix for that. Please review and let me know if I need to fix something.

Thanks!

@Ragnaruk
Copy link

I believe _execute should look like this:

    def _execute(
        self,
        query,
        args,
        limit,
        timeout,
        *,
        return_status=False,
        ignore_custom_codec=False,
        record_class=None
    ):
        query, compiled_args = compile_query(query, dialect=self._dialect)
        args = compiled_args or args
        return super()._execute(
            query,
            args,
            limit,
            timeout,
            return_status=return_status,
            record_class=record_class,
            ignore_custom_codec=ignore_custom_codec,
        )

Did your version work?

@Gr1N
Copy link
Contributor Author

Gr1N commented Feb 10, 2021

@Ragnaruk I ran tests with my fix and they passed

asyncpgsa/connection.py Outdated Show resolved Hide resolved
asyncpgsa/connection.py Outdated Show resolved Hide resolved
Copy link
Contributor

@nhumrich nhumrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is awesome. Good improvements to the build process as well!

nhumrich and others added 2 commits February 11, 2021 10:04
Co-authored-by: Freddie Lindsey <freddie.a.lindsey@gmail.com>
Co-authored-by: Freddie Lindsey <freddie.a.lindsey@gmail.com>
@nhumrich nhumrich merged commit b9e928c into CanopyTax:master Feb 12, 2021
@nhumrich
Copy link
Contributor

This is included in asyncpgsa 0.27.0

@Gr1N Gr1N deleted the support-asyncpg-0.22.0 branch February 12, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants