New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOAD_ERROR state does not exist in version 4.4.0 #397
Comments
👍 would you like to submit a pull request that adds this to the typescript definitions? |
@joeldenning |
LOAD_ERROR was added recently in #342. I checked out the minified published version of the code and it looks like it's missing the check for UserError which is weird. Will look into this more later. |
I just looked at this again and I was wrong about the published code having a problem. The published code appears to be totally fine. The typescript definitions are out of date, but other than that I see no problems here. I'll submit an update to the typescript definitions. See https://unpkg.com/single-spa@4.4.0/lib/esm/single-spa.min.js and search for LOAD_ERROR - you will see it is in there. If you'd like to report a different bug about your scenario where the application maybe did not go into LOAD_ERROR status when it should have, please do that as a separate bug. I'm going to treat this github issue as only the typescript definitions being out of date. |
Describe the bug or question
According to release note there should be LOAD_ERROR app state in version 4.4.0:
https://github.com/CanopyTax/single-spa/releases/tag/v4.4.0
To Reproduce
LOAD_ERROR app state is not available in the code in single-spa.d.ts (from npm):
Expected behavior
LOAD_ERROR app state should be available according to docs
The text was updated successfully, but these errors were encountered: