Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to set flame location #447

Merged
merged 1 commit into from May 13, 2017
Merged

Allow user to set flame location #447

merged 1 commit into from May 13, 2017

Conversation

jsantner
Copy link
Contributor

@jsantner jsantner commented Apr 6, 2017

A very small change that allows the user to set the initial location of the flame. The original hard-coded values for "locs" are retained as the default, but the user can now modify locs.

I've never created a pull request before, please let me know if I didn't do the fork/commit/pull process correctly.

A very small change that allows the user to set the initial location of the flame. The original hard-coded values for "locs" are retained as the default, but the user can now modify locs.
@codecov
Copy link

codecov bot commented Apr 6, 2017

Codecov Report

Merging #447 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
+ Coverage   59.12%   59.12%   +<.01%     
==========================================
  Files         384      384              
  Lines       40352    40347       -5     
  Branches     6689     6689              
==========================================
- Hits        23857    23855       -2     
+ Misses      14532    14529       -3     
  Partials     1963     1963
Impacted Files Coverage Δ
src/numerics/BandMatrix.cpp 58.28% <0%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52dbe8c...27f6970. Read the comment docs.

Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for the clean PR.

@speth speth merged commit 2a38b0a into Cantera:master May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants