Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent handling of marked duplicate Reactions #389

Closed
speth opened this issue Nov 14, 2016 · 0 comments
Closed

Inconsistent handling of marked duplicate Reactions #389

speth opened this issue Nov 14, 2016 · 0 comments
Labels

Comments

@speth
Copy link
Member

speth commented Nov 14, 2016

According to the documentation (reactions.rst):

If the ``'duplicate'`` option is specified, then the reaction not only *may*
have a duplicate, it *must*. Any reaction that specifies that it is a duplicate,
but cannot be paired with another reaction in the phase that qualifies as
its duplicate generates an error.

However, no such check is performed when importing reactions (see Kinetics::checkDuplicates)

As a point of reference, Chemkin does enforce this requirement when parsing reactions. Whether this is actually a useful check or not is a different question.

@speth speth added the Kinetics label Nov 14, 2016
@speth speth closed this as completed in 0fd2f7c Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant