Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make handling of Reactor Wall functions consistent #160

Closed
ischoegl opened this issue Jan 9, 2023 · 0 comments · Fixed by Cantera/cantera#1515
Closed

Make handling of Reactor Wall functions consistent #160

ischoegl opened this issue Jan 9, 2023 · 0 comments · Fixed by Cantera/cantera#1515
Labels
work-in-progress An enhancement that someone is currently working on

Comments

@ischoegl
Copy link
Member

ischoegl commented Jan 9, 2023

Abstract

Reactor walls define wall_Q as well as wall_vdot in clib, which have an explicit time dependency although the time is known internally (see Cantera/cantera#1182 (comment)). The Python API provides non-pythonic setters, and omits getters. An improved solution should be implemented that is consistent across all interfaces.

Motivation

Describe the need for the proposed change:

  • What problem is it trying to solve? ... inconsistent/incomplete interface
  • Who is affected by the change? ... new Matlab Interface Matlab toolbox revamp cantera#1182
  • Why is this a good solution? ... consistent interface

Possible Solutions

Update underlying C++ functions as needed and adapt Python/Matlab API's.

References

Cantera/cantera#1182

@ischoegl ischoegl added the feature-request New feature request label Jan 9, 2023
@ischoegl ischoegl added the help wanted Extra attention is needed label Mar 21, 2023
@ischoegl ischoegl added work-in-progress An enhancement that someone is currently working on and removed feature-request New feature request help wanted Extra attention is needed labels Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress An enhancement that someone is currently working on
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant