Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remaining classes in the Units interface #174

Open
16 tasks
bryanwweber opened this issue Apr 22, 2023 · 0 comments
Open
16 tasks

Implement remaining classes in the Units interface #174

bryanwweber opened this issue Apr 22, 2023 · 0 comments
Labels
feature-request New feature request

Comments

@bryanwweber
Copy link
Member

bryanwweber commented Apr 22, 2023

Abstract

In Cantera/cantera#991, an interface for ThermoPhase and PureFluid classes was implemented in cantera.with_units. This leaves all the other classes to be implemented, such as Kinetics, Interface, Reactor, etc.

Motivation

The request to customize units passed to Cantera functions has been around a long time (see #3). However, implementing all of the classes at the same time was prohibitively time consuming, so we settled on the minimum viable subset of the ThermoPhase class and the closely-related PureFluid class as a test to see how useful this interface will be. This leaves the rest of Cantera's interfaces to be implemented. This enhancement issue will document the remaining interfaces to be implemented, so they can be accomplished individually.

References

Supersedes #3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request
Projects
None yet
Development

No branches or pull requests

1 participant