New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog System #22
Merged
Merged
Dialog System #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic functions are: * xml_parse_doc - Parse the xml file * xml_verify_doc - Verify if it is the right document by checking the root node. * xml_free_doc - Free the allocated memory by the use document * cleanup_xml - Free all allocated memory used by the parser Not used but confirmed for working. Signed-off-by: Alexander Preisinger <alexander.preisinger@gmail.com>
Signed-off-by: Alexander Preisinger <alexander.preisinger@gmail.com>
Most Improtant libxml2 types are: * XML_ELEMENT_NODE * XML_TEXT_NODE * XML_COMMENT_NODE Also added documentation for xml_node_t and xml_type_t Signed-off-by: Alexander Preisinger <alexander.preisinger@gmail.com>
Signed-off-by: Alexander Preisinger <alexander.preisinger@gmail.com>
Signed-off-by: Alexander Preisinger <alexander.preisinger@gmail.com>
dlg_parse_file and dlg_free are the only functions at the moment dlg_content_next (or similar) will be the next one to implement Renamed functions in xml.c and xml.h Segfaults on broken dialog files Signed-off-by: Alexander Preisinger <alexander.preisinger@gmail.com>
Documentation still missing. Signed-off-by: Alexander Preisinger <alexander.preisinger@gmail.com>
I also implemented the function dlg_requirement_next to be more consistent and you don't have to directly interact with glib2. |
Yeah, I see no reason why not to merge this. Go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes the dialog system is finished (and partly tested).
The documentation is still missing and it needs more testing, but I like to have it in staging so that people can look at it and find mistakes or stuff that could be done better. It is also very error prone and it may segfault on broken dlg.xml (my suffix suggestion for dialog files) files. But still have a look it and tell me what you think.
In the next few days I like to build a proper test suite and more dialog files. Also better handling of wrong name nodes in the xml files.
I hope this code example does a good job on explaining how it works.
EDIT: You have all rights to hurt me if you saw my earlier usage of the switch statement in my commit history.
EDIT2: I forgot that It also features requirments for dialogs.
EDIT3: More usable example with new function