Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

提一个小bug #3728

Closed
panzhenglian opened this issue Dec 28, 2022 · 1 comment
Closed

提一个小bug #3728

panzhenglian opened this issue Dec 28, 2022 · 1 comment

Comments

@panzhenglian
Copy link

GSYVideoView 类中的 setUp(String url, boolean cacheWithPlay, File cachePath, Map<String, String> mapHeadData, String title) 方法,是播放点击时,prepareVideo()自动触发的,但是在 prepareVideo()方法中,将 this.mMapHeadData 传入了setUp 方法中,
setUp 方法中,将this.mMapHeadData.clear(),同时又操作 this.mMapHeadData.addAll(mapHeadData),这样做没有任何意义,因为他们是持有的同一个对象引用,导致 head必然被清空,代码改动很小,我已经在本地改动了。

@CarGuo
Copy link
Owner

CarGuo commented Jan 3, 2023

setUpLazy 才回会 prepareVideo 时的 setUp 操作吧? setUpLazy 已经弃用了其实

image

@CarGuo CarGuo closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants