Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated all gems to fix security issues #103

Merged
merged 3 commits into from
Aug 30, 2018
Merged

Conversation

vkoves
Copy link
Contributor

@vkoves vkoves commented Aug 15, 2018

Description of Changes:

Updated gems to fix security issues pointed out by GitHub. We should test this to make sure everything still works fine.

Here are the gems GitHub pointed out issues with:
screenshot from 2018-08-12 12-15-18

Tests Added:

None.

Reference Related Issue(s) or Spec Requirement:

N/A

Checklist:

  • Code follows code style of this project
  • Tests added to cover changes
  • All new and existing tests passing

Questions / Additional Notes:

@vkoves vkoves reopened this Aug 15, 2018
@coveralls
Copy link

coveralls commented Aug 15, 2018

Pull Request Test Coverage Report for Build 252

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.143%

Totals Coverage Status
Change from base Build 250: 0.0%
Covered Lines: 102
Relevant Lines: 105

💛 - Coveralls

Rails did this automatically upon running migrations
@vkoves
Copy link
Contributor Author

vkoves commented Aug 23, 2018

@AcademyInPeril - can you review this PR? A quick test should suffice

Copy link
Collaborator

@SorenSpicknall SorenSpicknall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working, as far as I can tell.

@vkoves vkoves merged commit 82fdf6f into master Aug 30, 2018
@vkoves vkoves deleted the update-insecure-gems branch August 30, 2018 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants