Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprites Using Index Colour Mode Changing Colours On Scroll #7

Closed
ClaytonMT opened this issue Feb 21, 2024 · 5 comments
Closed

Sprites Using Index Colour Mode Changing Colours On Scroll #7

ClaytonMT opened this issue Feb 21, 2024 · 5 comments
Assignees
Labels
bug Something isn't working Extension: BG Autoscroll

Comments

@ClaytonMT
Copy link

Hi,

Describe the bug
When using the script with an asesprite file that is using Colour Mode: Indexed, it changes the colours of the layer it is applied to.

To Reproduce
Colour Mode Indexed file, apply script to a coloured layer - the resulting frames (and original) are recoloured.

Expected behavior
Colour stays the same, background is given scrolling animation

Screenshots
Before:
image

After:
image

System Information (please complete the following information):
Win 10 Pro

Additional context
NA

Thanks!

@ClaytonMT ClaytonMT added the bug Something isn't working label Feb 21, 2024
@CarbsCode CarbsCode changed the title BG Auto-Scroll Changing Colours Sprites Using Index Colour Mode Changing Colours On Scroll Feb 21, 2024
@CarbsCode
Copy link
Owner

This is def not intended behavior, thank you for submitting this issue!

Would you be able to let me know which version of the tool and of which Aseprite version you are currently using?

Also if possible would you be able to send this .ase file so I could dig deeper in to this? Curious as to how the layers and/or colors are set up in your project! If not I will try and re-produce with the steps above to see if I can get it to happen!

Thank you!

@ClaytonMT
Copy link
Author

Hi,

Thanks for the swift reply!

Sure:

Auto-Scroll v1.1.4
Aseprite v1.3.2-x64

I had to zip the file to upload it as it does not allow .ase.

run_try.zip

There were only 2 layers as this was meant to be a file where I test characters running. I removed the layer with the player character, and the issue persists. I uploaded the file with the background only (before script is applied).

Regards,
Clayton

@ClaytonMT
Copy link
Author

Hi,

Any luck on fixing this please?

Regards,
Clayton

@CarbsCode
Copy link
Owner

CarbsCode commented Apr 4, 2024

This seems to be an index color mode issue. Everything works as intended when swaping to RGB color mode. Very strange! Also sorry for the delay on this @ClaytonMT I had some other obligations that have kept me from digging back in to this eariler!

As a work around and temporary fix would be flipping in to rgb color mode (via Sprite>Color Mode> RGB) performing the scroll then flipping back in to index mode!

Digging deeper in to why index mode is messing with things though.

EDIT: Ah I think I have found the issue actually! It has to do with how the tool copies the sprites over and uses a temp new sprite to perform the scroll with wrapping. It wasn't keeping your current color palette so what your seeing is your sprite entering the temp tab with a default palette (with less colors) then when the sprite goes back to the original it doesn't have the indexes set correctly any more and why it looks like the colors are in fact changing!

This whole system is very outdated and very much old code from when I had originally created the tool some few years ago. Granted this problem had never surfaced till recently. In v2.0 which I'm a bit in the middle of... well before the forementioned obligations, I was re-writing this part of the code anyhow as I need it to also work with a set selection instead of the full canvas.

Anyhow long story short I see the issue and I will try and patch it up if possible so you don't have to wait for the complete re-write version!

@CarbsCode
Copy link
Owner

Great news! I was able to get this fixed on the update I currently have in the works.

Planning to work on a few other features this weekend and hope to try and push this out soon. I will close this issue once the update is public! Thanks again for reporting this @ClaytonMT !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Extension: BG Autoscroll
Projects
None yet
Development

No branches or pull requests

2 participants