Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLB: Venture into Undercity #254

Closed
Hanmac opened this issue May 5, 2022 · 4 comments · Fixed by #502 or #720
Closed

CLB: Venture into Undercity #254

Hanmac opened this issue May 5, 2022 · 4 comments · Fixed by #502 or #720

Comments

@Hanmac
Copy link
Contributor

Hanmac commented May 5, 2022

Venture Effect needs to be extended to set a Specific Dungeon (Undercity). Going into that Dungeon is part of #252

And this Dungeon can't be get into unless specific defined.

@Northmoc
Copy link
Contributor

I think I can tackle this one if that's OK with you

@Hanmac
Copy link
Contributor Author

Hanmac commented May 25, 2022

shouldn't be that complicated, just make a UnderCity$ True param or something

@Hanmac
Copy link
Contributor Author

Hanmac commented Jun 13, 2022

Venture into [quality] is a variant of venture into the dungeon. If a player is instructed to “venture into [quality]” while they don’t own a dungeon card in the command zone, they choose a dungeon card they own from outside the game with the indicated quality and put it into the command zone.

meaning we should treat Undercity in the Venture Effect as a Subtype.

for this, CardType needs to be update to not collide with "Dungeon Master"

@Northmoc
Copy link
Contributor

I did begin to modify Venture Effect to look at subtypes for the new param instead of looking at the card name, but the Dungeon Master issue shut me down.

I am slammed right now but hope to get some time to go after it later this week.

Thanks for the insight and pertinent rulings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
2 participants