Global DamageHistory

[tool4ever]

Small diagram to show the new structure:

• closes Indulge // Excess #365
• closes Gnoll War Band #685
• closes Dragon Cultist #684

a single call in GameAction.dealDamage creates all the data
because we keep a DamageHistory Collection in Game they're already grouped by source so no need to manually merge with timestamps

[Hanmac]

Check out the thing with Gnoll War Band https://www.youtube.com/watch?v=hvha1anEVag

some cards check if players where dealt damage this turn (even if they left the game)
some cards check if players currently in the game where dealt damage this turn (that didn't left the game)

so a global history alone might not be the right thing?

[tool4ever]

Yea that's not too difficult to do now

Gonna add it

[tool4ever]

I realized some corner cases need LKI of target too:

Creature A equipped with Thirsting Axe deals combat damage to B, but if B then gets turned into non-creature before EOT, the trigger would still sacrifice A

[Northmoc]

Exciting! Will this help with Zangief?

[tool4ever]

Exciting! Will this help with Zangief?

Hmn, not that much I'm afraid. It still has the problem of the trigger condition timing with combat damage afair.
Do you still have that branch in your fork?

[Northmoc]

Exciting! Will this help with Zangief?

Hmn, not that much I'm afraid. It still has the problem of the trigger condition timing with combat damage afair. Do you still have that branch in your fork?

Yes, I still have it on my local drive. I don't think it's on my GitHub fork.

[Northmoc]

Looks good to me! Thanks for the big refactor!

[Northmoc]

🥳