Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement ssl #4

Open
IJustDev opened this issue Oct 14, 2019 · 2 comments
Open

Re-implement ssl #4

IJustDev opened this issue Oct 14, 2019 · 2 comments
Labels
enhancement New feature or request hacktoberfest

Comments

@IJustDev
Copy link
Contributor

IJustDev commented Oct 14, 2019 •
edited
Loading

The current server (http-package) does not support SSL encryption. We should introduce the https package.

Files to change: app.js
@IJustDev IJustDev added enhancement New feature or request hacktoberfest labels Oct 14, 2019
@MgenGlder
Copy link

Can you give a few more details about what you're trying to accomplish?

@IJustDev
Copy link
Contributor Author

Sure. I want the server to offer an option for SSL support. We should also add an environment variable for the folder containing the priv.key and the fullchain.pem. Those two values are needed for the https package.

I think it would be useful if we add another env variable representing whether SSL is enabled or not. (I suggest calling it SSL_ENABLED)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MgenGlder @IJustDev