Skip to content

Commit

Permalink
Merge branch 'develop' of github.com:CardinalPath/gas into develop
Browse files Browse the repository at this point in the history
  • Loading branch information
eduardocereto committed Apr 18, 2012
2 parents f4ad2c2 + bc23a7f commit 42a47b9
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 7 deletions.
1 change: 1 addition & 0 deletions .gitignore
Expand Up @@ -2,6 +2,7 @@
Thumbs.db
Icon?
*.swp
*.swo
*~
*.zip
_site
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Expand Up @@ -3,7 +3,7 @@
CLOSURE_COMPILER = java -jar ~/compiler.jar --compilation_level ADVANCED_OPTIMIZATIONS
#CLOSURE_COMPILER = java -jar ~/compiler.jar --compilation_level ADVANCED_OPTIMIZATIONS --formatting PRETTY_PRINT
#CLOSURE_COMPILER = java -jar ~/compiler.jar --formatting PRETTY_PRINT
UGLIFYJS = uglifyjs -v
UGLIFYJS = uglifyjs --ascii -v

# http://code.google.com/closure/utilities/index.html
CLOSURE_LINTER = gjslint
Expand Down
3 changes: 1 addition & 2 deletions src/core.js
Expand Up @@ -30,7 +30,6 @@ var document = window.document,
slice = Array.prototype.slice,
trim = String.prototype.trim,
sindexOf = String.prototype.indexOf,
aindexOf = Array.prototype.indexOf,
url = document.location.href,
documentElement = document.documentElement;

Expand All @@ -40,7 +39,7 @@ var document = window.document,
*/
function GAS() {
var self = this;
self['version'] = '1.6';
self['version'] = '1.7';
self._accounts = {};
self._accounts_length = 0;
self._queue = _prev_gas;
Expand Down
4 changes: 2 additions & 2 deletions src/header.js
@@ -1,8 +1,8 @@
/**
* @preserve Copyright 2011, Cardinal Path and Direct Performance.
* @preserve Copyright 2011, Cardinal Path and DigitalInc.
*
* GAS - Google Analytics on Steroids
* https://bitbucket.org/dpc/gas
* https://github.com/CardinalPath/gas
*
* @author Eduardo Cereto <eduardocereto@gmail.com>
* Licensed under the GPLv3 license.
Expand Down
3 changes: 2 additions & 1 deletion src/plugins/mailto.js
Expand Up @@ -27,7 +27,8 @@ var _gasTrackMailto = function(opts) {

this._liveEvent('a', 'mousedown', function(e) {
var el = e.target;
if (el && el.href && el.href.toLowerCase().indexOf('mailto:') === 0) {
if (el && el.href && el.href.toLowerCase &&
sindexOf.call(el.href.toLowerCase(), 'mailto:') === 0) {
_gas.push(['_trackEvent', opts['category'], el.href.substr(7)]);
}
});
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/outbound.js
Expand Up @@ -32,7 +32,7 @@ var _gasTrackOutboundLinks = function(opts) {
var l = this;
if (
(l.protocol == 'http:' || l.protocol == 'https:') &&
sindexOf.call(l.href, document.location.hostname) === -1)
sindexOf.call(l.hostname, document.location.hostname) === -1)
{
var path = (l.pathname + l.search + ''),
utm = sindexOf.call(path, '__utm');
Expand Down

0 comments on commit 42a47b9

Please sign in to comment.