server crash on client disconnect

[bazola]

It seems like sometimes disconnecting from the server causes it to error in such a way that it can no longer send messages to clients

[Zomis]

Whoops... any stack trace on this? Is it with the HTML5 LibGDX client or does it happen with other clients as well? Could it be #191 that hasn't been fully fixed?

[Zomis]

From the logfile I received I find two problems:

• Stack Overflow Error
• End Of File Exception

Both of these should be addressed, separately.

Stack Overflow Error

The Stack Overflow error is caused by this:

(...)
at com.cardshifter.core.game.ServerGame.send(ServerGame.java:95)
at com.cardshifter.server.model.Server.lambda$onDisconnected$3(Server.java:171)
(...)
at com.cardshifter.server.model.Server.onDisconnected(Server.java:171)
at com.cardshifter.api.ClientIO.disconnected(ClientIO.java:57)
at com.cardshifter.server.clients.ClientWebSocket.onSendToClient(ClientWebSocket.java:42)
at com.cardshifter.api.ClientIO.sendToClient(ClientIO.java:27)
at com.cardshifter.core.game.ServerGame.lambda$send$22(ServerGame.java:95)
(...)

These things seem to be repeated.

EOFException

End Of File Exception is likely caused by incompatibility between LibGDX code and the parent project. I'd recommend doing gradlew clean install on the real Cardshifter project, and then clean the LibGDX project to make it update the dependency for cardshifter-api.

[jacwah]

Is the stack overflow solved by #352? If not, how can I reproduce it?

[Zomis]

Stack Overflow error has been fixed, yes. As for EOFException, I think that is not a global bug, only a local one (because of incompatible versions between the gdx project and main Cardshifter repo).