Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to the project #33

Closed
marcandregirard opened this issue Feb 10, 2015 · 5 comments
Closed

Add tests to the project #33

marcandregirard opened this issue Feb 10, 2015 · 5 comments
Assignees

Comments

@marcandregirard
Copy link
Contributor

We should have tests in the project to make sure we don't break things. By example, we should have tests to make sure all page renders correctly.

We could even have some integration tests if needed be. But the first draft should contain at least the tests to make sure all pages render.

@Phrancis
Copy link
Contributor

I'm not sure what you have in mind, but I think a test to check all internal links are properly referenced to the controller on each of the pages would be useful. Currently I find myself testing each new link manually to make sure I don't have errors.

@marcandregirard
Copy link
Contributor Author

I'm not sure how we would test link, but it's definitely those kinds of things I want to test. I guess for testing links, we could use Selenium or some automated component to test this.

@Phrancis
Copy link
Contributor

Phrancis commented Apr 2, 2015

Was the game rules test the last one that you were planning to fix?

@marcandregirard
Copy link
Contributor Author

It was the last one I had planned to fix, but not the last one to implement. I would like to tests, that the page is well formed, like specific HTML elements are present. Exemple: verify that the navigation menu on the left point to all the right URL like something that would look like : asserThat(element ).linkTo("/cards") (you get the idea). It would be a step higher than just test if the page has rendered correctly.

@marcandregirard
Copy link
Contributor Author

We now have some unit tests. There are no integration tests but at the moment I don't plan to add that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants