Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowed filtering of ended arrangements #662

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Allowed filtering of ended arrangements #662

merged 4 commits into from
Jul 28, 2023

Conversation

jaysengardner
Copy link
Contributor

No description provided.

@LarsKemmann LarsKemmann linked an issue Jul 14, 2023 that may be closed by this pull request
Allow filtering of ended arrangements on the family screen #629
Open
LarsKemmann
LarsKemmann requested changes Jul 14, 2023
View reviewed changes
Copy link
Member

@LarsKemmann LarsKemmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A decent start but needs some more work and testing.

src/caretogether-pwa/src/Families/FamilyScreen.tsx Show resolved Hide resolved
src/caretogether-pwa/src/Families/FamilyScreen.tsx Outdated Show resolved Hide resolved
@jaysengardner
Copy link
Contributor Author

Fixed a logic error that was present in my original code. Images provided to show that it is now working as intended.

@jaysengardner jaysengardner marked this pull request as draft July 22, 2023 00:34
@jaysengardner
Copy link
Contributor Author

Screenshot (1)

@jaysengardner
Copy link
Contributor Author

Screenshot (2)

@jaysengardner jaysengardner marked this pull request as ready for review July 22, 2023 00:36
@LarsKemmann
Copy link
Member

Fixed a logic error that was present in my original code. Images provided to show that it is now working as intended.

I don't see an ended arrangement in your screenshots, nor any indication of what you set the filter options to.

@LarsKemmann LarsKemmann mentioned this pull request Jul 24, 2023
Closed
LarsKemmann
LarsKemmann approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@LarsKemmann LarsKemmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!!

@LarsKemmann LarsKemmann merged commit fec6beb into CareTogether:main Jul 28, 2023
1 check passed
@LarsKemmann LarsKemmann mentioned this pull request Jul 28, 2023
Open
@jaysengardner jaysengardner deleted the 629-allow-filtering-of-ended-arrangement branch July 28, 2023 22:47
@jaysengardner jaysengardner restored the 629-allow-filtering-of-ended-arrangement branch July 28, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LarsKemmann LarsKemmann LarsKemmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow filtering of ended arrangements on the family screen
2 participants
@jaysengardner @LarsKemmann