Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/741 referral selection #745

Merged
merged 7 commits into from
Jul 14, 2024
Merged

Feature/741 referral selection #745

merged 7 commits into from
Jul 14, 2024

Conversation

donschaefer
Copy link
Collaborator

@LarsKemmann - please review this PR to address issue #741 when you have some time. While testing, please pay special attention to...

  1. the "Incomplete" section (as it's hard to tell whether or not it's getting updated appropriately when switching referrals with the test data available) &
  2. the "Documents" section (given that it appears as though documents are meant to persist with the family rather than being referral specific, so I think they're not meant to be updated, but I'm not positive that's an accurate assumption)

@donschaefer donschaefer added ui This involves work on the user interface. ux For issues related to user experience labels May 28, 2024
@donschaefer donschaefer self-assigned this May 28, 2024
@donschaefer donschaefer linked an issue May 28, 2024 that may be closed by this pull request
Ability to select the referral to view on the family screen #741
Closed
@LarsKemmann
Copy link
Member

@donschaefer I started testing with live data and ran into two issues. One, I haven't been able to isolate yet, but the other I can reproduce with the test data: open the "Emmett Brown" partnering family and choose 'Close Referral'. I get the following error:
image

@donschaefer
Copy link
Collaborator Author

@donschaefer I started testing with live data and ran into two issues. One, I haven't been able to isolate yet, but the other I can reproduce with the test data: open the "Emmett Brown" partnering family and choose 'Close Referral'. I get the following error: image

This particular issue should now be resolved @LarsKemmann. Please let me know what you find in terms of the other intermittent issue you were seeing.

@LarsKemmann
Copy link
Member

@donschaefer I haven't been able to reproduce the other issue so I'm going to merge this. Thank you for all your efforts on this one! It's going to be a big help -- a seemingly small but functionally very important step in the direction we want to go.

@LarsKemmann LarsKemmann merged commit a5489d0 into CareTogether:main Jul 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LarsKemmann LarsKemmann LarsKemmann approved these changes

Assignees

@donschaefer donschaefer

Labels
ui This involves work on the user interface. ux For issues related to user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to select the referral to view on the family screen
2 participants
@donschaefer @LarsKemmann