Automatic generation of Vex.Extract protocol when using Vex.Struct appears broken in 1.14.1

[darraghenright]

Hi folks 👋

I hope all is well. The documentation suggests that protocols are automatically generated for structs when using Vex.Struct but this appears to be broken since 1.14.

I copy-pasted the example presented in the In Structs section of the README to reproduce:

1. I created a vanilla mix project.
2. I created a new file called user.ex and copy-pasted the User module from the example into it.
3. I created a function called validate_user and added the usage example into it.
4. I ran the command both via the command line with mix run -c and interactively in iex.

Findings:

• Version 1.12.3-otp-24 works as expected.
• Version 1.13.4-otp-24 works as expected.
• Version 1.14.1-otp-24 throws Protocol.UndefinedError.

The full error is:

(Protocol.UndefinedError) protocol Vex.Extract not implemented for %User{username: "actualuser", password: "abcdefghi", password_confirmation: "abcdefghi"} of type User (a struct). This protocol is implemented for the following type(s): Kernel, List, Map, Tuple
(vex 0.9.0) lib/vex/extract.ex:1: Vex.Extract.impl_for!/1
(vex 0.9.0) lib/vex/extract.ex:3: Vex.Extract.settings/1
(vex 0.9.0) lib/vex.ex:14: Vex.valid?/1

I had a look through the 1.14 changelog. Not much jumped out, the only thing I noticed was the following:

[Protocol] Expand :for in protocols with the appropriate env

I don't know if it's related. I'm still looking into that, and will update if I find out anything else.

[darraghenright]

A small update:

• The changelog message above is a misnomer, that's from 1.14.2. The functionality is broken since 1.14.1.
• I can confirm that the functionality does in fact also work in 1.14.0-rc.1 (installed 1.14.0-rc.1-otp-24 via asdf)

So clearly something changed after that release candidate.

[darraghenright]

Had a quick chat about this in Elixir Slack and turns out this was a bug in Elixir version 1.14.1 which was fixed in 1.14.2:

elixir-lang/elixir#12186

I am happy to confirm that upgrading to 1.14.2 fixes the issue. Closing!

[mudassirkhan19]

@darraghenright , looks like we are bumping into the same problems across projects 😄