Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix addNode to return true when node is added to anchor #117

Merged
merged 3 commits into from Jul 4, 2022

Conversation

Levizzel
Copy link
Contributor

Hey,
as mentioned in #113 the addNode function returns false every time when the node is added to an anchor.
In the changes from v0.6.3 true is only returned if the node is added to the scene and not if the node is added to an anchor.

I added the return for each Node-Type in Andorid and iOS.
I have checked it for Andoroid but can't do it for iOS.

@CariusLars
Copy link
Owner

thanks for the fix @Levizzel!

@CariusLars
Copy link
Owner

Could you write an entry for your fixes into changelog.md and set a new minor version number in the readme and the pubspec.yaml? Happy to merge after that :)

@Levizzel
Copy link
Contributor Author

Done @CariusLars. I never contributed to a repo so I hope 0.7.0 is the right version number

@CariusLars
Copy link
Owner

@Levizzel could you actually make it 0.6.5 instead? Sorry for the back and forth, that one was my fault, 0.7.0 would be a new minor version (which is what I asked previously) but I now realized this should only be a patch, so it should be 0.6.5

@Levizzel
Copy link
Contributor Author

@CariusLars Okay. Done!

@CariusLars CariusLars merged commit 0d01bf0 into CariusLars:main Jul 4, 2022
@CariusLars
Copy link
Owner

just merged, thanks for the contribution @Levizzel !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants