New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added scaling (pinch) functionality #118
Conversation
fix: flutter 3 compatibility
fix: removed stray ` char from podfile example
Please be sure to attached files in the right folders. Libs.zip into lib folder of plugin. AndroidArView.zip in the android main folder |
Solved: Also added minScale (0.1f) and maxScale (10.0f) |
Hey @SebastianAT, as far as I can see there are no code changes? Haven´t had the chance to look into the files you attached yet but could you explain why there are no commits form you in this PR? Sorry for the confusion and really appreciate that you are contributing to this plugin :) |
Hey unfortunately i could not Upload kotlin files directly so i had to put
the files in zip files and then i uploaded it. Maybe it does not recognize
those files.
But they are attached, please verify this manually.
Can you tell me how i can achivie to use Material color change of a local
GLTF file?
Chees
Sebastian
Lars Carius ***@***.***> schrieb am So., 26. Juni 2022, 20:43:
… Hey @SebastianAT <https://github.com/SebastianAT>, as far as I can see
there are no code changes? Haven´t had the chance to look into the files
you attached yet but could you explain why there are no commits form you in
this PR? Sorry for the confusion and really appreciate that you are
contributing to this plugin :)
—
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGIWA3CV42HFAZQTONFR6A3VRCQD3ANCNFSM5ZML7RQA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Unfortunately it's almost impossible to review like this because I can't see the diffs... Why did committing and pushing the kotlin files not work? what's the output of |
as you see on the image github does not allow me to upload kotlin files ... idk why... i did not copy the whole repo i just wanted to upload by the webpage github provides. To see the difference just take the old file and the new file and check on this site: https://www.diffchecker.com/ and now you will be able to see the differences. If you were not able i will try another workaround and download the whole repo and push it back with the state of me. |
For Android i have added pinchgesture functionality in order to be able to scale the model. Only problem i did not found to set a limit on max or min scale.
AndroidARView.zip
libs.zip