Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added scaling (pinch) functionality #118

Closed
wants to merge 7 commits into from
Closed

added scaling (pinch) functionality #118

wants to merge 7 commits into from

Conversation

SebastianAT
Copy link

For Android i have added pinchgesture functionality in order to be able to scale the model. Only problem i did not found to set a limit on max or min scale.
AndroidARView.zip
libs.zip

@SebastianAT
Copy link
Author

Please be sure to attached files in the right folders. Libs.zip into lib folder of plugin. AndroidArView.zip in the android main folder

@SebastianAT
Copy link
Author

Solved: Also added minScale (0.1f) and maxScale (10.0f)
ArModelBuilder.zip
e

@CariusLars
Copy link
Owner

Hey @SebastianAT, as far as I can see there are no code changes? Haven´t had the chance to look into the files you attached yet but could you explain why there are no commits form you in this PR? Sorry for the confusion and really appreciate that you are contributing to this plugin :)

@SebastianAT
Copy link
Author

SebastianAT commented Jun 27, 2022 via email

@CariusLars
Copy link
Owner

Unfortunately it's almost impossible to review like this because I can't see the diffs... Why did committing and pushing the kotlin files not work? what's the output of git status after the changes you applied?

@SebastianAT
Copy link
Author

image

as you see on the image github does not allow me to upload kotlin files ... idk why... i did not copy the whole repo i just wanted to upload by the webpage github provides.

To see the difference just take the old file and the new file and check on this site: https://www.diffchecker.com/ and now you will be able to see the differences.

If you were not able i will try another workaround and download the whole repo and push it back with the state of me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants