Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace EOK with 0 #40

Open
linguini1 opened this issue May 19, 2024 · 0 comments
Open

Replace EOK with 0 #40

linguini1 opened this issue May 19, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@linguini1
Copy link
Collaborator

Turns out that EOK is a QNX-specific macro (which is crazy to me, but POSIX defines literally every other error type in an enum of E* names except EOK as 0).

To properly be POSIX compatible, we should either:

  • Replace occurrences of EOK with 0
  • Add a #define EOK 0 somewhere in a common header file so that our code will compile elsewhere

I do like the readability of EOK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant