Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn this into a monorepo #433

Open
CarloLucibello opened this issue May 4, 2024 · 8 comments
Open

turn this into a monorepo #433

CarloLucibello opened this issue May 4, 2024 · 8 comments

Comments

@CarloLucibello
Copy link
Owner

We want to host in this repo 2 packages, GNNlib.jl (#432) and GraphNeuralNetworks.jl. In the future there will be another frontend like GraphNeuralNetworks.jl based on Lux.jl.

We want to host all of that into a single repo instead of multiple ones in order to facilitate development, since very likely a PR will often change both GNNlib.jl and the other repo.

Useful discussions on monorepos:
https://discourse.julialang.org/t/anything-to-be-wary-of-when-registering-a-subpackage/112459
https://discourse.julialang.org/t/how-beacon-packages-julia-code-in-a-monorepo/90822/9
JuliaLang/Pkg.jl#3263

An example of monorepo:
https://github.com/gdalle/DifferentiationInterface.jl

@gdalle
Copy link

gdalle commented May 5, 2024

To be fair, I only added the Register action because a user asked for it repeatedly in an issue, but I don't actually use it 😇

@gdalle
Copy link

gdalle commented May 5, 2024

I also havent completely figured out the testing mechanism cause both repos depend on one another for tests. At the moment I think you cannot test DifferentiationInterface if you downloaded it alone, which kinda sucks

@CarloLucibello
Copy link
Owner Author

To be fair, I only added the Register action because a user asked for it repeatedly in an issue, but I don't actually use it 😇

I did try but cannot manage to make it work https://github.com/CarloLucibello/GraphNeuralNetworks.jl/actions

@gdalle
Copy link

gdalle commented May 5, 2024

Yeah I had tried that a few times too and hit similar errors that I didn't understand, so I gave up

@CarloLucibello
Copy link
Owner Author

For local development instead I found this comment pointing at a solution
JuliaLang/Pkg.jl#3263 (comment)
So I think that instead of deving the packages, one has to clone the repo and try to use this shared manifest trick.
I don't know if julia 1.10 supports it already, probably not.

@gdalle
Copy link

gdalle commented May 5, 2024

Right but my point about local testing is that people should be able to do

using Pkg
Pkg.add("DifferentiationInterface")
Pkg.test("DifferentiationInterface")

and it should just work. Right now it doesn't because my DifferentiationInterface runtests.jl looks for DifferentiationInterfaceTest in the folder next door

@gdalle
Copy link

gdalle commented May 5, 2024

I don't know if julia 1.10 supports it already, probably not.

Doesn't show up on https://pkgdocs.julialang.org/v1.10/toml-files/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants