Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect output when using birthday next #5

Closed
Carnagion opened this issue Oct 22, 2022 · 1 comment
Closed

Incorrect output when using birthday next #5

Carnagion opened this issue Oct 22, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Carnagion
Copy link
Owner

The birthday next command produces incorrect output.

The cause is that when sorting birthdays, their original years are used, which leads to them being sorted according to years first, then months, then days.
The intended behaviour is for birthdays to be sorted according to months and days only.

A possible fix would be to map() the birthdays to dates with the current year and UTC timezone before sorting them, though this would result in the allocation of another Vec<DateTime<Utc>>.

@Carnagion Carnagion added the bug Something isn't working label Oct 22, 2022
@Carnagion
Copy link
Owner Author

Fixed in #6.

@Carnagion Carnagion self-assigned this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant