Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import-Export buttons in common tag component #1730

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Import-Export buttons in common tag component #1730

wants to merge 4 commits into from

Conversation

KD1712
Copy link
Collaborator

@KD1712 KD1712 commented Jul 3, 2024 •
edited
Loading

This PR adds Action buttons which toggle between Import/Export icons w.r.t Tag value

@KD1712 KD1712 self-assigned this Jul 3, 2024
@KD1712 KD1712 linked an issue Jul 3, 2024 that may be closed by this pull request
Import / Export button #1714
Open
@KD1712 KD1712 requested a review from danoswaltCL July 3, 2024 14:29
@danoswaltCL
Copy link
Collaborator

can you put a screenshot on here?

are we okay with allowing the state to potentially be "true" for both buttons, or should this strictly be a toggle (can't have a state where both are true)? Potentially "action buttons" like these that will live in an input deserve to be their own widget and have a slot like we do for section card header-right action buttons. @zackcl @Yagnik56

@Yagnik56
Copy link
Collaborator

Yagnik56 commented Jul 4, 2024 •
edited
Loading

can you put a screenshot on here?

are we okay with allowing the state to potentially be "true" for both buttons, or should this strictly be a toggle (can't have a state where both are true)? Potentially "action buttons" like these that will live in an input deserve to be their widget and have a slot like we do for section card header-right action buttons. @zackcl @Yagnik56

it should be a toggle, when tags are empty it should show import otherwise export. @khanjan, can you refer to the design and make the change accordingly

@KD1712
Copy link
Collaborator Author

KD1712 commented Jul 4, 2024

Screenshot 2024-07-04 at 3 10 35 PM Screenshot 2024-07-04 at 12 27 18 PM

The icons will toggle accordingly if we edit the tags. Just need to add functionality for icon click in parent component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yagnik56 Yagnik56 Awaiting requested review from Yagnik56

@danoswaltCL danoswaltCL Awaiting requested review from danoswaltCL

At least 1 approving review is required to merge this pull request.

Assignees

@KD1712 KD1712

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import / Export button
3 participants
@KD1712 @danoswaltCL @Yagnik56