include setting on item
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added setting `include` to item's configuration (value can be string or array of strings) - added method `IMenuItem::setInclude()` - added test
|
Thank you, good work 👍 Do you think you could also add some note into the readme file please? |
|
Of course, here it is 🙂 |
|
@davidkudera can you merge it please? 🙂 |
|
@tg666 sure, I was just waiting for you with the review. You should see one a bit above here. Can you please fix it? I'll merge it immediately afterwards. |
jelen07
suggested changes
Apr 23, 2018
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| namespace Carrooi\Menu\Loaders; | |||
|
|
|||
| use Nette\Utils; | |||
|
Thank you and good job 👍 also sorry for the problems.... |
|
No problem, thank you too 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includeto item's configuration (value can be string or array of strings)IMenuItem::setInclude()