Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary-only dependencies don't have a version file for --cache-builds #1904

Closed
mdiep opened this issue Apr 27, 2017 · 2 comments
Closed

binary-only dependencies don't have a version file for --cache-builds #1904

mdiep opened this issue Apr 27, 2017 · 2 comments

Comments

@mdiep
Copy link
Member

mdiep commented Apr 27, 2017

  • carthage version: 0.21

Cartfile

binary "https://some/my-project.json"

Carthage Output

*** No cache found for my-project, building with all downstream dependencies

Evidently this wasn't covered by #1850. 😞

@erichoracek
Copy link
Member

@mdiep hmm—quite strange! I tested that version files are being outputted. See below:

$ mkdir TestBinary
$ cd TestBinary

$ carthage version
0.21.0

$ echo 'binary "https://www.mapbox.com/ios-sdk/Mapbox-iOS-SDK.json"' > Cartfile

$ carthage bootstrap
*** No Cartfile.resolved found, updating dependencies
*** Downloading binary-only framework Mapbox-iOS-SDK at "https://www.mapbox.com/ios-sdk/Mapbox-iOS-SDK.json"
*** xcodebuild output can be found in /var/folders/9s/rl0z7g591cs9frc53y6cbpzm0000gq/T/carthage-xcodebuild.gSiAcr.log

$ carthage build --cache-builds
*** xcodebuild output can be found in /var/folders/9s/rl0z7g591cs9frc53y6cbpzm0000gq/T/carthage-xcodebuild.NiXbi0.log
*** Valid cache found for Mapbox-iOS-SDK, skipping build

$ ls -al Carthage/Build 
total 8
drwxr-xr-x  4 user  staff  136 Apr 27 08:28 .
drwxr-xr-x  3 user  staff  102 Apr 27 08:28 ..
-rw-r--r--  1 user  staff  222 Apr 27 08:28 .Mapbox-iOS-SDK.version
drwxr-xr-x  4 user  staff  136 Apr 27 08:28 iOS

$ cat Carthage/Build/.Mapbox-iOS-SDK.version 
{
  "iOS" : [
    {
      "hash" : "256b13073b6ea18ecff56214ba3540e39d8a4610f84cb8a5019df58768ab00ee",
      "name" : "Mapbox"
    }
  ],
  "commitish" : "3.5.2",
  "watchOS" : [

  ],
  "tvOS" : [

  ],
  "Mac" : [

  ]
}

Is there something I'm missing—perhaps another example binary project to try that doesn't perform like this?

@mdiep
Copy link
Member Author

mdiep commented Apr 27, 2017

Hmm… It looks like the issue is that I just ran carthage build and not carthage bootstrap.

So I guess we can chalk this up to state from a pre-0.21 checkout.

@mdiep mdiep closed this as completed Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants