Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart Documentation changes #2008

Closed
michellemho opened this issue Jan 12, 2018 · 2 comments
Closed

Quickstart Documentation changes #2008

michellemho opened this issue Jan 12, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@michellemho
Copy link

Hi Carto.js team! I ran into these issues while following the Quickstart documentation and wanted to log them here.

Quickstart Documentation issues:

<script src="https://cartodb-libs.global.ssl.fastly.net/carto.js/%VERSION%/carto.min.js"></script>
  • Consider changing %VERSION% to the latest carto.js version (v4.0.0-beta.10) in the code example in the Quickstart guide, or make a clear note that the user should replace the version with the latest.

  • Couldn't find documentation on carto.layer.events.FEATURE_OVER (found in the Quickstart guide) in the References... is this the equivalent of 'featureOver'?

  • When adapting the Quickstart code to create a pop-up when mousing over contiguous polygons, I found that the pop-up content never disappears or updates! My solution was to remove the if (!popup.isOpen()) statement in the pop-up code, which made me wonder if it was necessary in the first place?

  • Finally, it would be nice to see the final map from the Quickstart guide to understand expected behavior 😄

@Jesus89 Jesus89 added this to the v4.0.0 milestone Jan 31, 2018
@csubira
Copy link
Contributor

csubira commented Feb 2, 2018

Hi @michellemho!
Thanks a lot for reporting!

  • As you said %VERSION% should be the latest carto.js version so, you found a bug!
    Fixed right now!
  • There's also an open ticket here -> Events documentation #2013 regarding the same topic. Let's see if by tackling/ solving that issue your doubts are cleared out too.
  • Maybe if you contact @IagoLast or @Jesus89 to show them what you've been working on, they can help you with that!
  • Yes! Done!

@csubira csubira closed this as completed Feb 2, 2018
@ivanmalagon
Copy link
Contributor

Hi Michelle!

Regarding your popup question, it's true that the code it's only updating contents when showing the popup again, which is OK with the example dataset, sparse points. Every time you hover a point you're sure that the popup has been closed before. In your case, with continuous polygons or a dense network of point, it won't work. Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants