Fix bounding box issue #1080
Closed
Fix bounding box issue #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello new attributions
Widgets tooltip
New full screen button
Added default zoom template + moved view to zoom folder
fix transition
Was previously located in DI but actually belongs here
Since bins now are set a default in the dataview, and the test case should not test the full URL but the presence of the set bbox attr
Fixes wrong attribute name ownFilter -> enableFilter
So specrunners are up-to-date with tests available in the local web server
The exact same code is present in the "super" method so this object was being bound to the "change:enabled" event twice. This was causing the dataview to fetch it's data twice when dataview was re-enabled.
Removed duplicated binding
Fixing change about how to parse data within category dataview
Fix problem with category filter when accepts a category where it was rejected
Belongs to widgets, not a concern for a dataview really
Reload map on prefix+suffix change on category dataview
Was faulty changed in 2e9b0ea39440d8bca812c0665b7 6e114a3e54e17#diff-51a09ea5f3b9485ac7865588bdfa1082R18 it was given as `category` from DI: https://github.com/CartoDB/deep-insights.js/pull/138/files#diff-eb62919d bc9c6c8e66ffed48ee679a92L39, although in the `toJSON` we have the hardcoded `aggregation` value: https://github.com/CartoDB/cartodb.js/blob/2e9b0ea39440d8bca812c0665b76e 114a3e54e17/src/dataviews/category-dataview-model.js#L249 It should be category as type still since some code depends on it.
Change type to category again
…e thing it was supposed to do (according to it's name)
Fixed `enableFilter` flag on the category dataview model
…ng-box Ensure `submitBBox` is set to true after the first fetch in the histogram dataview
|
@alonsogarciapablo I think you wanted to merge into |
|
Totally! Re-opening! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1070, by reverting this commit.
@viddo PTAL! Thanks!
NOTE to @viddo : this might have some effects on the deep-insights.js test suite since I remember you mentioning something related (there's some history about it on slack)