Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PostgreSQL] New UI #15339

Closed
10 tasks done
alejandraarri opened this issue Dec 20, 2019 · 7 comments
Closed
10 tasks done

[PostgreSQL] New UI #15339

alejandraarri opened this issue Dec 20, 2019 · 7 comments
Assignees

Comments

@alejandraarri
Copy link
Contributor

alejandraarri commented Dec 20, 2019

We want to develop a new UI for the existing Database connectors in the Import API. The idea is to generate some screens so the user can connect to the desired database, run an SQL query and import the resulting dataset into the CARTO Dashboard. We are going to start developing the UI for the Postgres connector, but it should be easy to make it extensible to MySQL and to SQL Server connectors.

Related info

Acceptance

Connectors enablement

  • Login with dbconnectorsui user
  • Check that all db connectors are disabled (PostgreSQL, MySQL, SQL Server)
  • Edit account and enable carto-connectors in the Feature flags section
  • Login again and check that all db connectors are enabled

Connectors' tests

Connection parameters are in this document https://docs.google.com/document/d/1qnkvzJPHeBTvDYbe27S1v4AnCsem9RfDcd3mpvxep3E/edit?usp=sharing

  • Click on the PostgreSQL connector button, it will take you to connection params page.
  • Check that all copies and logos refer to PostgreSQL.
  • Try to connect with wrong params and check than an error message appears.
  • Connect with correct params and check that it takes you to SQL query screen.
  • Type a query without from keyword and run query. An error should appear.
  • Type a correct query and import a table. Sync options cannot be tested in dedicated instances.
  • Repeat with other connectors
  • Repeat from Add new layer option from a map in Builder

Note: Back button goes back to Connectors list page

@kukukaka
Copy link

@MireyaD do you mind checking with @alejandraarri if the PostgreSQL design is ready to go and make the changes that are needed? Some issues where I can see we need some more work:

  • Assets
  • It's the design feasible? I notice that in the BigQuery one we use a single column while the MySQL here uses a double-column, would that be a problem?
  • I would remove the links to the help articles until we tackle them
  • Are the copies final? Did you check them with @vdiego?

Thanks!
/cc @urbanphes

@MireyaD
Copy link

MireyaD commented Jan 13, 2020

Sure! @alejandraarri and I are having a meeting today to check if something else is needed :)

@MireyaD
Copy link

MireyaD commented Jan 14, 2020

Hey! After yesterday meeting we have some open questions:

  • Should we include in the first screen a Contact us link? Can we manage the amount of messages? Or we would have the same situation as in the request connector case?
  • IP are correct?
  • @vdiego, could you check the copies?

Bitmap@1x

Bitmap@1x

Bitmap@1x

Bitmap@1x

Let me know what you think. Thanks!

@vdiego
Copy link

vdiego commented Jan 14, 2020

@MireyaD done! I left comments in invision :)

@MireyaD
Copy link

MireyaD commented Jan 15, 2020

Thanks @vdiego! I updated the design with the copies.

https://invis.io/QUULMAVESAW#/390965265_Connect

@MireyaD
Copy link

MireyaD commented Jan 22, 2020

Hey!

I updated the Invision project with two types of error messages:

@alejandraarri
Copy link
Contributor Author

Deployed into production! 🚀
In the end, working for all DB connectors: PostgreSQL, MySQL and SQL server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants