Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include description columns in data requests #593

Closed
alrocar opened this issue Apr 5, 2019 · 2 comments
Closed

Include description columns in data requests #593

alrocar opened this issue Apr 5, 2019 · 2 comments

Comments

@alrocar
Copy link
Contributor

alrocar commented Apr 5, 2019

Description columns are removed from the request because the copyto query was failing.

The problem may be due to copyto does not support POST requests.

To test this:

  • Remove the FIXME in cc.data method
  • Run the test_data test
@javitonino
Copy link

Why is this related with POST? Query length?

@alrocar
Copy link
Contributor Author

alrocar commented Apr 8, 2019

Yes I was assuming it was because the query length. We were including the whole columns descriptions in the DO query, but as per this comment it may be not necessary.

SO I guess we can remove the FIXME and close this issue.

Eventually the POST issue may be a problem, but I guess this is not something we have to fix in CARTOframes.

@alrocar alrocar closed this as completed Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants