NO-TICKET: Fix era cleanup. #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code accidentally cleaned up the current era instead of the old one.
fizyk20
approved these changes
Mar 1, 2021
|
bors r+ |
|
Build failed: |
|
As discussed, we ignore RUSTSEC-2020-0146 for now. |
|
bors r+ |
|
I created NDRS-956 for RUSTSEC-2020-0146. |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Mar 4, 2021
1052: NDRS-955: Make tests include unbonding and dropping eras. r=afck a=afck This changes the configuration used in the reactor tests so that the 5-era tests cause eras to become unbonded and dropped in the era validator. This would have made the tests catch the bug fixed in #1038. https://casperlabs.atlassian.net/browse/NDRS-955 1064: OP-1882: refactor itst scenarios r=goral09 a=TomVasile Moves common functions used in itst scenarios into a common sourceable script. Co-authored-by: Andreas Fackler <andreas@casperlabs.io> Co-authored-by: TomVasile <43349666+TomVasile@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code accidentally cleaned up the current era instead of the old one.