HWY-249: Add the timestamp to CandidateBlock.
#879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validity of a proto block depends on the timestamp. If there are two different candidate blocks (belonging to different units) with the same proto block, we must not apply the validity result to both.
goral09
reviewed
Feb 7, 2021
| @@ -192,20 +192,25 @@ impl<I> Era<I> { | |||
| pub(crate) fn resolve_validity( | |||
| &mut self, | |||
| proto_block: &ProtoBlock, | |||
| timestamp: Timestamp, | |||
There was a problem hiding this comment.
This is a timestamp of the unit that proposed the ProtoBlock?
There was a problem hiding this comment.
…and it will be the timestamp of the FinalizedBlock and Block itself.
There was a problem hiding this comment.
Can you add a comment or improve the name? In order to figure out what the timestamp is here one has to go up a couple of levels and then down into another branch where it was created.
goral09
approved these changes
Feb 7, 2021
goral09
reviewed
Feb 7, 2021
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validity of a proto block depends on the timestamp. If there are two different candidate blocks (belonging to different units) with the same proto block, we must not apply the validity result to both.
https://casperlabs.atlassian.net/browse/HWY-249