NDSR-907: Migrate accounts CSV into TOML. #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpapierski
requested review from
Fraser999,
asladeofgreen,
henrytill and
EdHastingsCasperAssociation
EdHastingsCasperAssociation
approved these changes
Feb 19, 2021
Co-authored-by: Joe Sacher <321623+sacherjj@users.noreply.github.com>
sacherjj
approved these changes
Feb 19, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 19, 2021
957: NDSR-907: Migrate accounts CSV into TOML. r=EdHastingsCasperLabs a=mpapierski Ref: https://casperlabs.atlassian.net/browse/NDRS-907 This PR replaces accounts.csv into a structured TOML file in preparation to hold delegators data there as well. New structure: ```toml [[accounts]] public_key = "01522ef6c89038019cb7af05c340623804392dd2bb1f4dab5e4a9c3ab752fc0179" balance = "1000000000000000000000000000" bonded_amount = "0" ``` Co-authored-by: Michał Papierski <michal@casperlabs.io>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
goral09
reviewed
Feb 22, 2021
| account = { | ||
| 'public_key': key_hex, | ||
| 'balance': f'{motes}', | ||
| 'staked_amount': f'{weight}' |
There was a problem hiding this comment.
Is it "bonded amount" or "staked amount"? You need to be consistent.
bors bot
added a commit
that referenced
this pull request
Feb 22, 2021
965: NO-TICKET: Fix `nctl` scripts. r=goral09 a=goral09 #957 broke `nctl` scripts – it used `staked_amount` where `bonded_amount` was [expected](https://github.com/CasperLabs/casper-node/blob/master/node/src/types/chainspec/accounts_config.rs#L24). Co-authored-by: Mateusz Górski <gorski.mateusz@protonmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://casperlabs.atlassian.net/browse/NDRS-907
This PR replaces accounts.csv into a structured TOML file in preparation to hold delegators data there as well.
New structure: