Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EntryResource converter from optimade-python-tools #15

Closed
CasperWA opened this issue Feb 13, 2020 · 3 comments
Closed

Use EntryResource converter from optimade-python-tools #15

CasperWA opened this issue Feb 13, 2020 · 3 comments
Assignees
@CasperWA

Comments

@CasperWA
Copy link
Owner

To be more versatile, it would be good to have OPTiMaDe structure converters, e.g., to pymatgen, ase, and AiiDA.

It may be that these should be part of a Materials-Consortia repository instead, intended for use by clients.
@CasperWA CasperWA self-assigned this Apr 8, 2020
@CasperWA
Copy link
Owner Author

CasperWA commented Apr 8, 2020 •
edited

This is initially implemented in the pure_jupyter_version branch, and since moved "upstream" to the optimade package in the optimade-python-tools in the PR Materials-Consortia/optimade-python-tools#241.
Once that PR is merged, it can be implemented in this client.

@CasperWA
Copy link
Owner Author

We can now use the adapter in optimade-python-tools v0.8.0.

@CasperWA CasperWA changed the title Structure converters Use EntryResource converter from optimade-python-tools May 5, 2020
@CasperWA CasperWA mentioned this issue May 12, 2020
Merged
@CasperWA
Copy link
Owner Author

Fixed in #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CasperWA CasperWA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CasperWA