Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make voila and jupyterlab optional dependencies. #183

Closed
yakutovicha opened this issue Oct 12, 2020 · 1 comment · Fixed by #184
Closed

Make voila and jupyterlab optional dependencies. #183

yakutovicha opened this issue Oct 12, 2020 · 1 comment · Fixed by #184
Labels
dependencies Pull requests that update a dependency file

Comments

@yakutovicha
Copy link
Collaborator

When I was trying to build the AiiDAlab environment, I realized that the optimade-client depends on Jupyter Lab and voila which, in turn, require tornado to be higher than 5.0. This makes it impossible to build a consistent environment, as AiiDA requires tornado to be strictly lower than 5.0.

The possible solution would be to make those dependencies optional and install them only when the [voila] extra is set.

@CasperWA CasperWA added the dependencies Pull requests that update a dependency file label Oct 12, 2020
@CasperWA
Copy link
Owner

The cons here being that the nice and simple "pip install and run optimade-client" won't work anymore. One would instead have to specifically add the the extra to the install to make it work.

This I find acceptable, and will respect the package, since it essentially has two purposes:

  1. Provide Jupyter widgets to be used in Jupyter notebooks.
  2. Provide a Voilà application that can be run locally (and in Docker).

This change will simply make the split of these purposes explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants