Handle Groups with Delimiter::None
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, rustc does not pass the exact original `TokenStream` to proc-macros in several cases. This has many undesirable effects, such as losing correct location information in error message. See rust-lang/rust#43081 for more details In the future, rustc will begin passing the correct `TokenStream` to proc-macros. As a result, some tokens may be wrapped in a `TokenTree::Group` with `Delimiter::None` (when the tokens originally came from a `macro_rules!`) macro expansion. I've determined that this change will cause your crate to stop compiling. This PR updates `obfstr` to be compatible with both the old and new `TokenStream` contents. You can verify this PR by attempting to build your crate as follows: ``` rustup toolchain install nightly-2020-05-29 cargo +nightly-2020-05-29 build ``` This will built your crate with an older nightly build that contains the change we want to eventually roll out. On this compiler version, your crate should fail to compile without this PR, and successfully compile with this PR. If you have any questions, feel free to ask me for more details.
|
I didn't notice #9: feel free to close this PR if it's no longer necessary 😄 |
|
Thanks! Don't worry about #9 as it's an experiment and needs a fairly recent nightly to compile while this crate right now works on stable. Your breaking change (bugfix by another name :) just made me revisit this crate so I tried pushing const fn and const generic as far as I could. Which worked pretty well :) |
Aaron1011
added a commit
to Aaron1011/obfstr
that referenced
this pull request
Jul 27, 2020
In PR CasualX#10, I didn't properly handle all of the cases where `None`-delimited groups can appear. This makes the tests pass with the Nightly build from the previous PR.
CasualX
pushed a commit
that referenced
this pull request
Jul 29, 2020
In PR #10, I didn't properly handle all of the cases where `None`-delimited groups can appear. This makes the tests pass with the Nightly build from the previous PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, rustc does not pass the exact original
TokenStreamtoproc-macros in several cases. This has many undesirable effects, such as
losing correct location information in error message.
See rust-lang/rust#43081 for more details
In the future, rustc will begin passing the correct
TokenStreamtoproc-macros. As a result, some tokens may be wrapped in a
TokenTree::GroupwithDelimiter::None(when the tokens originallycame from a
macro_rules!) macro expansion.I've determined that this change will cause your crate to stop
compiling. This PR updates
obfstrto be compatible with both theold and new
TokenStreamcontents.You can verify this PR by attempting to build your crate as follows:
This will built your crate with an older nightly build that
contains the change we want to eventually roll out.
On this compiler version, your crate should fail to compile without this
PR, and successfully compile with this PR.
If you have any questions, feel free to ask me. See rust-lang/rust#72622 for more details